-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auth form visual enhancements (olive) #766
feat: Auth form visual enhancements (olive) #766
Conversation
- Hide preloaders for third party auth providers if they disabled - Suggested usernames container enlargement for mathing to neighboring inputs
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #766 +/- ##
============================================================
Coverage ? 81.22%
============================================================
Files ? 86
Lines ? 1870
Branches ? 540
============================================================
Hits ? 1519
Misses ? 337
Partials ? 14 ☔ View full report in Codecov by Sentry. |
Hi @zainab-amir! Product is all set with this. Please review and merge if all looks good to you. Thanks! |
Hi @zainab-amir - friendly ping on this :) |
@mphilbrick211 the change in master branch is already in review and waiting for author: #767 |
e6bc861
to
60afe8c
Compare
779275f
into
openedx:open-release/olive.master
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Cosmetic improvements for the login/registration page. Changes in React are related to the situation when third-party login providers is disabled, but when switching between Login and Registration tabs, we still see a preloader that is not necessary in this situation.
2023-03-01.16.08.24.mov
And sass changes are related to the suggested username field, which is too short and can be extended to match the neighboring inputs.
After making our changes, we no longer see preloaders in cases where third-party login providers are turned off.
2023-03-01.16.47.42.mov
And suggested username field looks pretty