Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth form visual enhancements (olive) #766

Conversation

Lunyachek
Copy link
Contributor

Description

Cosmetic improvements for the login/registration page. Changes in React are related to the situation when third-party login providers is disabled, but when switching between Login and Registration tabs, we still see a preloader that is not necessary in this situation.

2023-03-01.16.08.24.mov

And sass changes are related to the suggested username field, which is too short and can be extended to match the neighboring inputs.

image1

After making our changes, we no longer see preloaders in cases where third-party login providers are turned off.

2023-03-01.16.47.42.mov

And suggested username field looks pretty

Снимок экрана 2023-03-01 в 16 46 17

- Hide preloaders for third party auth providers if they disabled
- Suggested usernames container enlargement for mathing to neighboring inputs
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 1, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 1, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Lunyachek Lunyachek changed the title feat: Auth form visual enhancements feat: Auth form visual enhancements (olive) Mar 1, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 1, 2023
@jmakowski1123 jmakowski1123 added the product review PR requires product review before merging label Mar 1, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/olive.master@dabf556). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/olive.master     #766   +/-   ##
============================================================
  Coverage                             ?   81.22%           
============================================================
  Files                                ?       86           
  Lines                                ?     1870           
  Branches                             ?      540           
============================================================
  Hits                                 ?     1519           
  Misses                               ?      337           
  Partials                             ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @zainab-amir! Product is all set with this. Please review and merge if all looks good to you. Thanks!

@mphilbrick211
Copy link

Hi @zainab-amir! Product is all set with this. Please review and merge if all looks good to you. Thanks!

Hi @zainab-amir - friendly ping on this :)

@zainab-amir
Copy link
Contributor

@mphilbrick211 the change in master branch is already in review and waiting for author: #767
This is the same change but for the olive branch. Same changes are required here too.

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 17, 2023
@Lunyachek Lunyachek force-pushed the lunyachek/feat/auth-form-visual-enhancements-olive branch from e6bc861 to 60afe8c Compare July 21, 2023 23:03
@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. and removed product review PR requires product review before merging labels Oct 24, 2023
@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 21, 2024
@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Apr 17, 2024
@syedsajjadkazmii syedsajjadkazmii merged commit 779275f into openedx:open-release/olive.master Apr 19, 2024
2 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants