Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #299

Merged
merged 6 commits into from
May 12, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 15, 2023

Ticket

Upgrade Node JS from 16 to 18

edx-internal PR

https://github.com/edx/edx-internal/pull/8352

This needs to be merged together

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@BilalQamar95 BilalQamar95 self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ffc53d) 83.19% compared to head (ea04fb8) 83.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files          38       38           
  Lines         708      708           
  Branches      221      221           
=======================================
  Hits          589      589           
  Misses        115      115           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review May 11, 2023 11:10
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally, lgtm

@alex-sheehan-edx alex-sheehan-edx merged commit 3655661 into main May 12, 2023
@alex-sheehan-edx alex-sheehan-edx deleted the bilalqamar95/node-v18-upgrade branch May 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants