Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate off modal paragon deprecated component #71

Merged
merged 4 commits into from
May 5, 2023

Conversation

Mashal-m
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed?

  • Migrate off paragon modal deprecation in WarningModal.jsx

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #71 (199bf61) into main (eb0fa82) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          68       68           
  Lines         911      911           
  Branches      247      247           
=======================================
  Hits          806      806           
  Misses         98       98           
  Partials        7        7           
Impacted Files Coverage Δ
src/instructions/proctored_exam/WarningModal.jsx 75.00% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -5.12 ⚠️

Comparison is base (070e96b) 93.68% compared to head (befc88c) 88.57%.

❗ Current head befc88c differs from pull request most recent head 6fa9e9f. Consider uploading reports for the commit 6fa9e9f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   93.68%   88.57%   -5.12%     
==========================================
  Files          70       68       -2     
  Lines        1014      910     -104     
  Branches      279      248      -31     
==========================================
- Hits          950      806     -144     
- Misses         59       97      +38     
- Partials        5        7       +2     
Impacted Files Coverage Δ
src/instructions/proctored_exam/WarningModal.jsx 100.00% <100.00%> (+25.00%) ⬆️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes
Copy link
Contributor

@leangseu-edx, any chance you could review this?

@Mashal-m, mind updating the branch with master in the meantime?

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't ModalDialog.body is uppercase?
Anyway, can you use ModalDialogBody, ModalDialogHeader`.... syntax instead? Since those are import directly and it is less likely to create typo and it is easier to check with the doc on paragon https://paragon-openedx.netlify.app/components/modal/modal-dialog/

@Mashal-m Mashal-m force-pushed the mashal-m/paragon-modal-deprecation branch from 3558267 to 2705d40 Compare January 24, 2023 08:38
@Mashal-m
Copy link
Contributor Author

Shouldn't ModalDialog.body is uppercase? Anyway, can you use ModalDialogBody, ModalDialogHeader`.... syntax instead? Since those are import directly and it is less likely to create typo and it is easier to check with the doc on paragon https://paragon-openedx.netlify.app/components/modal/modal-dialog/

According to paragon documentation, we can only import ModaDialog and ModalCloseButton directly. It is mandatory to use header, title, etc like this ModalDialog.Body.

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leangseu-edx
Copy link
Contributor

According to paragon documentation, we can only import ModaDialog and ModalCloseButton directly. It is mandatory to use header, title, etc like this ModalDialog.Body.

Fair. It seems all of the example are doing that.

@Mashal-m Mashal-m merged commit f61d7e8 into openedx:main May 5, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

🎉 This PR is included in version 2.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

dcoa pushed a commit to eduNEXT/frontend-lib-special-exams that referenced this pull request Jan 10, 2024
* refactor: migrate off modal paragon deprecated component

* refactor: fixed ModalDialog body uppercase

* refactor: change button tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants