Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ParameterHandler._OPENMMTYPE #1760

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Remove ParameterHandler._OPENMMTYPE #1760

merged 2 commits into from
Nov 30, 2023

Conversation

mattwthompson
Copy link
Member

Resolves #1745

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #1760 (e36c65b) into main (64621ae) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

j-wags
j-wags approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like _OPENMMTYPE is indeed not used anywhere else and is private to boot, so this should be good to go. I'm gonna kick tests a little to make sure they pass and will update releasenotes. Thanks @mattwthompson!

@j-wags j-wags merged commit b17f0fc into main Nov 30, 2023
16 checks passed
@j-wags j-wags deleted the remove-openmmtype branch November 30, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ParameterHandler._OPENMMTYPE
2 participants
@mattwthompson @j-wags