Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pytest 8 #1822

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Allow pytest 8 #1822

wants to merge 13 commits into from

Conversation

mattwthompson
Copy link
Member

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.86%. Comparing base (c303f30) to head (ed686ec).

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review February 5, 2024 18:20
@mattwthompson
Copy link
Member Author

Ha, I've gotten this error before but in a position where it didn't need to be fixed

=========================== short test summary info ============================
FAILED openff/toolkit/_tests/test_forcefield.py::TestForceField::test_load_bad_filelike_object - TypeError: argument of type 'NoneType' is not iterable
FAILED openff/toolkit/_tests/test_forcefield.py::TestForceField::test_do_not_load_in_child_dir - TypeError: argument of type 'NoneType' is not iterable
FAILED openff/toolkit/_tests/test_forcefield.py::TestForceField::test_load_bad_bytes - TypeError: argument of type 'NoneType' is not iterable
FAILED openff/toolkit/_tests/test_forcefield.py::TestForceField::test_load_bad_string - TypeError: argument of type 'NoneType' is not iterable

@mattwthompson mattwthompson force-pushed the pytest-8 branch 2 times, most recently from 5a1b105 to 8fc7d6e Compare February 6, 2024 18:25
@mattwthompson mattwthompson marked this pull request as draft February 6, 2024 19:01
@mattwthompson
Copy link
Member Author

mattwthompson commented Feb 15, 2024

Splitting off some more discrete ideas which might be nice to have in the installed package before this works nicely, starting with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant