Skip to content

Commit

Permalink
Address more review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nirvn committed Dec 22, 2024
1 parent 0a4edd5 commit 1520cb2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/app/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ int main( int argc, char **argv )
QCoreApplication::setOrganizationDomain( "opengis.ch" );
QCoreApplication::setApplicationName( qfield::appName );

// For now the service only deals with background attachment uploads;
// This service only deals with background attachment uploads;
// it will terminate once all uploads are done
QFieldCloudService app( argc, argv );
return 0;
Expand Down
3 changes: 3 additions & 0 deletions src/core/positioning/abstractgnssreceiver.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ class AbstractGnssReceiver : public QObject

QString lastError() const { return mLastError; }

/**
* Returns extra details (such as hdop, vdop, pdop) provided by the positioning device.
*/
virtual GnssPositionDetails details() const { return {}; }
virtual QAbstractSocket::SocketState socketState() const { return mSocketState; }
virtual QString socketStateString();
Expand Down

0 comments on commit 1520cb2

Please sign in to comment.