Apply suggestions from code review

opengisch · Apr 5, 2024 · 3ff492d · 3ff492d
1 parent 7bf4b81
commit 3ff492d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/cmake/qgis-cmake-wrapper.cmake b/cmake/qgis-cmake-wrapper.cmake
@@ -150,7 +150,6 @@ if(TRUE) # Should possibly have a "static only" check
       Qt::Positioning
       Qt::Core5Compat
     )
-  endif()
   if(NOT CMAKE_SYSTEM_NAME STREQUAL "iOS")
     find_package(Qt COMPONENTS SerialPort)
     target_link_libraries(QGIS::Core INTERFACE

diff --git a/src/app/CMakeLists.txt b/src/app/CMakeLists.txt
@@ -103,7 +103,7 @@ function(create_executable)
     qt_import_qml_plugins(${exe_TARGET} PATH_TO_SCAN
                           "${CMAKE_CURRENT_BINARY_DIR}/qmldrop/app")
   endif()
-  target_link_libraries(${exe_TARGET} PUBLIC Qt6::Core5Compat)
+  target_link_libraries(${exe_TARGET} PUBLIC Qt::Core5Compat)
   qt_import_plugins(${exe_TARGET} INCLUDE Qt::QSvgPlugin)
   qt_import_plugins(${exe_TARGET} INCLUDE Qt::Core5Compat)
 

diff --git a/src/qml/CMakeLists.txt b/src/qml/CMakeLists.txt
@@ -7,10 +7,9 @@ if(QtQuickCompiler_FOUND
    AND NOT CMAKE_BUILD_TYPE MATCHES RelWithDebInfo)
   qtquick_compiler_add_resources(
     QML_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/qml.qrc
-    ${CMAKE_CURRENT_SOURCE_DIR}/qmlqt6.qrc)
+    )
 else()
   qt_add_resources(QML_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/qml.qrc)
-  qt_add_resources(QML_SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/qmlqt6.qrc)
 endif()
 
 add_library(qfield_qml STATIC ${QML_SOURCES})