Add QField camera UI to toggle geotagging #4685
Conversation
| anchors.topMargin: 4 | ||
|
|
||
| iconSource: positionSource.active ? Theme.getThemeIcon("ic_geotag_24dp") : Theme.getThemeIcon("ic_geotag_missing_24dp") | ||
| iconColor: positionSource.active && settings.geoTagging ? Theme.mainColor : "white" |
There was a problem hiding this comment.
| iconColor: positionSource.active && settings.geoTagging ? Theme.mainColor : "white" | |
| iconColor: positionSource.active && settings.geoTagging ? Theme.mainColor : Theme.lightColor |
Isn't it better to avoid mixing themed and hardcoded colors?
There was a problem hiding this comment.
In this case, not really. I mean, we could have Theme.white, but I feel like it's not gaining much.
This specific color doesn't change across our light/dark theme either.
If we want to say have something like Theme.defaultToolButttonColor (being white) I suggest we do that in a separate PR as it'll touch a dozen QML files or so.
There was a problem hiding this comment.
Well, the idea is that if we decide to add another color theme in the future, we are not sure if the white will remain white. Probably your suggestion to have Theme.defaultToolButttonColor is even better. Lets merge like this for now.
|
🎉 Ta-daaa, freshly created APKs are available for 321c45f: arm64-android |
This PR adds a UI to the QField camera to toggle geotagging:
When enabled, the following tags are added: