Revert geometry/rubberband item's buffer parameter change #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 6a5522e: arm64-android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing a crasher that emerged in QField 3.0.3:
Stacktrace:
Looking at the list of commits (v3.0.2...v3.0.3) I can only see one culprit: the buffer parameter change here (869c197#diff-6ec0f90b884446f8c30d9dd753160c7e100e8929ae79edd44679d1df523bee57R167)
The logic behind that change was to reduce the number of vertices produced by the buffering operation as a tiny optimization. That appears to have had negative consequences. Let's revert.
(Note that the other change, the removeDuplicateNodes call in the rubber band, is important and not tied to the crash, hence keeping it in.