Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play it safe, use a QPointer to the map canvas item to reduce risks of crash #4856

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Play it safe, use a QPointer to the map canvas item to reduce risks of crash #4856

merged 2 commits into from
Dec 18, 2023

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Dec 16, 2023

Crash seen on google play store's crash reporting (which is becoming quite good):

backtrace:
  #00  pc 0x0000000001eb0264  /data/app/~~AidkTkmVejfLrdD_MYFiCA==/ch.opengis.qfield-thT7LfUTg_MgkCMOzMjSww==/lib/arm64/libqfield_arm64-v8a.so (QgsQuickMapCanvasMap::isRendering() const) (BuildId: a75578015316ac7d9753d901e88698581a3e774f)
  #01  pc 0x0000000001f8979c  /data/app/~~AidkTkmVejfLrdD_MYFiCA==/ch.opengis.qfield-thT7LfUTg_MgkCMOzMjSww==/lib/arm64/libqfield_arm64-v8a.so (QgisMobileapp::saveProjectPreviewImage()+52) (BuildId: a75578015316ac7d9753d901e88698581a3e774f)
  #02  pc 0x0000000001f89430  /data/app/~~AidkTkmVejfLrdD_MYFiCA==/ch.opengis.qfield-thT7LfUTg_MgkCMOzMjSww==/lib/arm64/libqfield_arm64-v8a.so (QgisMobileapp::loadProjectFile(QString const&, QString const&)+2420) (BuildId: a75578015316ac7d9753d901e88698581a3e774f)
  #03  pc 0x0000000001edd8ec  /data/app/~~AidkTkmVejfLrdD_MYFiCA==/ch.opengis.qfield-thT7LfUTg_MgkCMOzMjSww==/lib/arm64/libqfield_arm64-v8a.so (AppInterface::loadFile(QString const&, QString const&)+112) (BuildId: a75578015316ac7d9753d901e88698581a3e774f)
  #04  pc 0x0000000001fd0b80  /data/app/~~AidkTkmVejfLrdD_MYFiCA==/ch.opengis.qfield-thT7LfUTg_MgkCMOzMjSww==/lib/arm64/libqfield_arm64-v8a.so (Java_ch_opengis_qfield_QFieldActivity_openProject+148) (BuildId: a75578015316ac7d9753d901e88698581a3e774f)

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Dec 16, 2023 •
edited
Loading

🎉 Ta-daaa, freshly created APKs are available for 0f1d66d: arm64-android

Other architectures

@nirvn nirvn merged commit 10af994 into master Dec 18, 2023
19 checks passed
@nirvn nirvn deleted the save_project_preview_crash branch December 18, 2023 01:22
@qfield-fairy qfield-fairy mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirvn @qfield-fairy @suricactus