-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editable project variables. #5589
Conversation
🎉 Ta-daaa, freshly created APKs are available for c2931b8: arm64-android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
resets after close and reopening project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there. We can work on the saving/restoring of customized project variables in a different PR.
BTW, could we rename ApplicationScope to GlobalScope to match QGIS' terminology? That'll make it easier to read the code.
Description
This PR represents the second step in revamping the variables page within the settings. As you know in This PR, we introduced project variables to the existing list, which previously only displayed application-wide (global) variables.
In this step, we've made it possible to edit project variables (but unremovable). The changes will remain effective throughout the session, but once the project is closed and reopened, the values will revert to their original settings.
Stay tuned:
for step three, where we will focus on enhancing the visual design! :)
Demo:
You can see editable but unremovable project variables here: