-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic model for PositioningInformationView
#5604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now we made a model and in next step we should add some static variables in that model ( to support internal device mode too )
🎉 Ta-daaa, freshly created APKs are available for f43f996: arm64-android |
because PositioningModel is a bit generic.
mohsenD98
force-pushed
the
dynamic-positioning-info
branch
from
September 1, 2024 15:17
ef1bb47
to
e75383a
Compare
mohsenD98
changed the title
WIP - Dynamic model for
Dynamic model for Sep 2, 2024
PositioningInformationView
PositioningInformationView
nirvn
reviewed
Sep 2, 2024
nirvn
reviewed
Sep 2, 2024
And reset (X/Y-Lat/Lon) labels at coordinateDisplayCrsChanges.
nirvn
reviewed
Sep 3, 2024
nirvn
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's merge this.
nirvn
reviewed
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces enhancements to the PositioningInformationView.
Current State:
The current PositioningInformationView displays static
Text { }
elements in QML that vary in visibility based on the type of receiver (internal or external NMEA). The goal is to support displaying any details a receiver device can provide.Internal devices feature information such as:
External NMEA receivers provide these, plus additional attributes like:
New State:
We are replacing the static
Text { }
components with a dynamicGridView { }
backed by a custom model,PositioningInformationModel
. This model encompasses six core attributes that are common across all receivers:Latitude, Longitude, Altitude, Speed, Vertical Accuracy, and Horizontal Accuracy
. Additionally, there's adeviceDetails
variable of typeQList<QPair<QString, QVariant>>
.The
deviceDetails
list will hold other parameters specific to each receiver. For instance, in theNmeaGnssReceiver
, this implementation would look like:With this update, when a new receiver type is introduced, the only requirement is to implement the details function, allowing the UI to update seamlessly and automatically.