Improve feature attribute transfer by allowing copying _some_ expression-driven attributes #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we initially released this functionality, we turned out to be a bit too rigid on our handling of expression-driven attribute.
This PR relaxes things a bit by applying the prohibition on transfer of attribute values on attributes with default value expression to those that don't update their value on feature updates. The updated logic continues to protect users from overwriting UUID / unique value / timestamp attributes that would have been generated once on feature creation while allowing for expression-drive attributes set to refresh on feature update to have values transferred.