Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename QFieldService to QFieldCloudService #5906

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Rename QFieldService to QFieldCloudService #5906

merged 2 commits into from
Dec 21, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Dec 21, 2024

Let's make some syntax room for more services :)

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Dec 21, 2024

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will pretend I understand all the Java code :) . But I understand what you are doing here and it looks fine to me.

Just to clarify, the QFieldCloud service is now responsible for attachments, but it will be the very same service used for delta upload (if we ever implement this)?

@nirvn
Copy link
Member Author

nirvn commented Dec 21, 2024

@suricactus , correct. It'd be the very same service that could download large cloud projects in the background too.

@nirvn nirvn merged commit 8503089 into master Dec 21, 2024
24 checks passed
@nirvn nirvn deleted the service_rename branch December 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants