Add sentry patch for XCode 16 support #5913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a fix I had local which I didn't proposed here yet in a PR, related to XCode / iOS builds.
When using XCode 16, the build always fails due to an issue with the Sentry package. I checked if it was feasible to update the package, but as still version 7 of the package was used, and the fix only existed in 8 I decided to only apply the patch. Maybe in a future version the Sentry package can be updated, but I assume there is a reason why this hasn't been done yet?
The issue / PR from Sentry that describes the issue and why it is resolved is over here: getsentry/sentry-cocoa#4051