Get rid of focusstack in favor of a much cleaner Shortcut handling of escape/back keys #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for d57a1d1: arm64-android |
…elcome screen buttons visibility
nirvn
force-pushed
the
renew_stack
branch
2 times, most recently
from
e2537cf to
ce8163e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time, we came with FocusStack to handle the escape/back key. Since Qt 5.5, a new Shortcut item allows us to do something much cleaner, and avoid interfering with a bunch of Qt focus handling.
By making things cleaner, I'm hoping this will also improve how reliable our {tap,drag,etc.} handlers are too.