Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding critical message when path exceed 200 characters #622

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Adding critical message when path exceed 200 characters #622

merged 1 commit into from
Nov 15, 2024

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Nov 14, 2024 •
edited
Loading

Adding critical message when path exceed 200 characters.

Screenshot from 2024-11-14 16-11-46

Fixes #437

@SeqLaz SeqLaz requested a review from suricactus November 14, 2024 16:27
@m-kuhn
Copy link
Member

m-kuhn commented Nov 14, 2024

What does this fix?

@SeqLaz SeqLaz changed the title Adding critical message when path exceed 250 characters Adding critical message when path exceed 200 characters Nov 14, 2024
@SeqLaz SeqLaz force-pushed the QF-2101-adding_warning_for_long_path_names_for_export_folder branch from f380d49 to b606de6 Compare November 14, 2024 18:11
@SeqLaz
Copy link
Member Author

SeqLaz commented Nov 14, 2024

What does this fix?

@m-kuhn Long path names for the export folder cause issues on Windows. This prevents the user from exporting the project to the specified folder if it exceeds 200 characters.

@SeqLaz SeqLaz force-pushed the QF-2101-adding_warning_for_long_path_names_for_export_folder branch from b606de6 to 2c54dc4 Compare November 14, 2024 18:22
@m-kuhn
Copy link
Member

m-kuhn commented Nov 14, 2024

Is there an issue report explaining these problems?
Just to have a proper problem statement and paper trail.

@SeqLaz
Copy link
Member Author

SeqLaz commented Nov 14, 2024

Is there an issue report explaining these problems? Just to have a proper problem statement and paper trail.

@m-kuhn it was reported there #437

@m-kuhn
Copy link
Member

m-kuhn commented Nov 14, 2024 •
edited
Loading

Is there an issue report explaining these problems? Just to have a proper problem statement and paper trail.

@m-kuhn it was reported there #437

Thanks, can you add "fixes #437" to the pull request description?

Did it

@SeqLaz SeqLaz force-pushed the QF-2101-adding_warning_for_long_path_names_for_export_folder branch from 2c54dc4 to 1df7643 Compare November 14, 2024 22:10
@SeqLaz
Copy link
Member Author

SeqLaz commented Nov 14, 2024

Hey @suricactus, I addressed the suggestion and squashed to reduce the number of commits and to remove unneeded code!

suricactus
suricactus approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you both!

@suricactus suricactus merged commit 4ce2bb3 into master Nov 15, 2024
7 checks passed
@suricactus suricactus deleted the QF-2101-adding_warning_for_long_path_names_for_export_folder branch November 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long path names for export folder cause issues on windows
3 participants
@SeqLaz @m-kuhn @suricactus