feat(FormLabel): allow ReactNode instead of string (#560)

type can safely be expanded
opengovsg · Nov 21, 2023 · 34c11ee · 34c11ee
1 parent bcc2d8d
commit 34c11ee
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/react/src/FormControl/FormLabel/FormLabel.tsx b/react/src/FormControl/FormLabel/FormLabel.tsx
@@ -24,15 +24,15 @@ export interface FormLabelProps extends ChakraFormLabelProps {
   /**
    * Question number to be prefixed before each label, if any.
    */
-  questionNumber?: string
+  questionNumber?: React.ReactNode
   /**
    * Tooltip text to be postfixed at the end of each label, if any.
    */
-  tooltipText?: string
+  tooltipText?: React.ReactNode
   /**
    * Description text to be shown below the label text, if any.
    */
-  description?: string
+  description?: React.ReactNode
   /**
    * Label text.
    */
@@ -107,9 +107,7 @@ export const FormLabel = ({
 FormLabel.displayName = 'FormLabel'
 FormLabel.Label = ChakraFormLabel
 
-interface FormLabelDescriptionProps extends TextProps {
-  children: string
-}
+interface FormLabelDescriptionProps extends TextProps {}
 const FormLabelDescription: FC<FormLabelDescriptionProps> = ({
   children,
   ...props