add comment + better lint

opengovsg · Dec 30, 2024 · c7111cd · c7111cd
1 parent 670947f
commit c7111cd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/components/src/utils/getReferenceLinkHref.ts b/packages/components/src/utils/getReferenceLinkHref.ts
@@ -39,9 +39,11 @@ const convertReferenceLinks = (
     return originalLink
   }
 
-  const refPage = sitemapArray.find(
-    ({ id, indexPageId }) => refPageId === id || refPageId === indexPageId,
-  )
+  const refPage = sitemapArray.find(({ id, indexPageId }) => {
+    // in the case of a folder with IndexPage,
+    // we must check both the folder's id and the IndexPage's id
+    return refPageId === id || refPageId === indexPageId
+  })
 
   if (!refPage) {
     return originalLink

diff --git a/tooling/build/scripts/publishing/index.ts b/tooling/build/scripts/publishing/index.ts
@@ -115,10 +115,13 @@ async function main() {
           resource.fullPermalink.endsWith(INDEX_PAGE_PERMALINK) &&
           resource.type !== "RootPage"
 
-        const resourceConvertedPermalink = getConvertedPermalink(resource.fullPermalink)
+        const resourceConvertedPermalink =
+          getConvertedPermalink(resource.fullPermalink)
 
         const idOfFolder = resources.find(
-          (item) => isIndexPage && item.fullPermalink === resourceConvertedPermalink,
+          (item) =>
+            isIndexPage &&
+            item.fullPermalink === resourceConvertedPermalink,
         )?.id
 
         const sitemapEntry: SitemapEntry = {