Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow editing of published collection links #1000

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

dcshzj
Copy link
Contributor

@dcshzj dcshzj commented Jan 20, 2025

Problem

Published collection links do not have a draftBlobId, which causes an error in saving published collection links.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backwards compatible

Bug Fixes:

  • Use the correct function to update the blob (updateBlobById), as that function handles creating the draftBlobId if it is not present.

Tests

  • Create a collection link item within a collection.
  • Save changes to the collection link item and publish, make sure the publish button is greyed out and the publish is successful.
  • Make another change to the collection link.
  • Verify that the success toast message appears with the text "Link updated"

@dcshzj dcshzj requested a review from a team as a code owner January 20, 2025 10:43
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 20, 2025

Datadog Report

Branch report: fix/allow-edit-collectionlink
Commit report: 149438e
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 51.06s Total Time
➡️ Test Sessions change in coverage: 1 no change

@dcshzj dcshzj merged commit 505583b into main Jan 20, 2025
17 checks passed
@dcshzj dcshzj deleted the fix/allow-edit-collectionlink branch January 20, 2025 11:38
@harishv7
Copy link
Contributor

PR #1000 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants