Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom titles in index pages #1002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix: allow custom titles in index pages #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tooling/build/scripts/publishing/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ async function main() {
resource.parentId,
)

// NOTE: We remap the ID for _index pages to be the ID of the folder,
// as both will have the same permalink and the folder is recognized as
// the parent of all the children resources
const idOfFolder = resources.find(
(item) =>
resource.fullPermalink.endsWith(INDEX_PAGE_PERMALINK) &&
Expand Down Expand Up @@ -246,7 +249,13 @@ function generateSitemapTree(
)
.map((danglingDirectory) => {
const pageName = danglingDirectory.replace(/-/g, " ")
const title = pageName.charAt(0).toUpperCase() + pageName.slice(1)
const generatedTitle =
pageName.charAt(0).toUpperCase() + pageName.slice(1)
const folderResourceTitle = resources.find(
(resource) => resource.fullPermalink === danglingDirectory,
)?.title
const title = folderResourceTitle ?? generatedTitle

logDebug(
`Creating index page for dangling directory: ${danglingDirectory}`,
)
Expand Down
Loading