enhancement/add copyright year component #970
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 245 Passed, 36 Skipped, 53.16s Total Time |
dcshzj
approved these changes
Jan 3, 2025
| "use client" | ||
|
|
||
| export const ClientCopyrightYear = () => { | ||
| return <>© {new Date().getFullYear()} </> |
There was a problem hiding this comment.
nit: I think the space should be part of Footer.tsx rather than here? At first glance it wasn't clear why there was an additional space here.
There was a problem hiding this comment.
thanks for catching this! changed it in 077edc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the year is generated on build time
But ideally, we want it to be generated on runtime since we don't know when will agencies trigger a new build + it's easier than having to remember to trigger a new build for all sites every new year
Solution
Breaking Changes
Improvements:
use clientfor the copyright and year