Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/infocols non link should not change colour on hover #971

Merged

Conversation

adriangohjw
Copy link
Contributor

Problem

Currently, Infocol item with no link, changes colour on hover too. This can be misleading in terms of UX

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • do not change colour on hover if it does not have a link

Tests

review the new story in storybook

@adriangohjw adriangohjw added the bug Something isn't working label Jan 2, 2025
@adriangohjw adriangohjw self-assigned this Jan 2, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 2, 2025 05:40
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 2, 2025

Datadog Report

Branch report: fix/infocols-non-link-should-not-change-colour-on-hover
Commit report: f5ad526
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 48.5s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.01%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • vitest run --coverage 3.8% (-0.01%) - Details

@adriangohjw adriangohjw merged commit fde927f into main Jan 3, 2025
18 checks passed
@adriangohjw adriangohjw deleted the fix/infocols-non-link-should-not-change-colour-on-hover branch January 3, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants