-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement - collection tagfilters first #973
Merged
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 257 Passed, 36 Skipped, 47.59s Total Time |
… enhancement/collection-tagfilters-first
dcshzj
approved these changes
Jan 3, 2025
Base automatically changed from
enhancement-collection-do-not-render-empty-filter
to
main
January 7, 2025 10:30
…cement/collection-tagfilters-first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tags are rendered at the bottom after "Category" and "Year"
However, tags are likely more important and useful as a filter than "Year", and arguably the same for "Category"
Closes https://opengovproducts.slack.com/archives/C07CWUNUL68/p1735803802912019?thread_ts=1735799448.795359&cid=C07CWUNUL68
Solution
Breaking Changes
Improvements:
Note: ideally we pass in the ordering via
CollectionMeta
but that seems to be an overkill for nowTests