Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - collection tagfilters first #973

Merged
merged 21 commits into from
Jan 7, 2025

Conversation

adriangohjw
Copy link
Contributor

Problem

Tags are rendered at the bottom after "Category" and "Year"

However, tags are likely more important and useful as a filter than "Year", and arguably the same for "Category"

Closes https://opengovproducts.slack.com/archives/C07CWUNUL68/p1735803802912019?thread_ts=1735799448.795359&cid=C07CWUNUL68

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Improvements:

  • change the order of filters to be Tags > Category > Year

Note: ideally we pass in the ordering via CollectionMeta but that seems to be an overkill for now

Tests

  1. Find a collection with multitags, more than 1 categories and 1 year
  2. Trigger a codebuild
  3. Review the order of the published collection page and that it should be "Tags > Category > Year"

@adriangohjw adriangohjw added the enhancement New feature or request label Jan 2, 2025
@adriangohjw adriangohjw self-assigned this Jan 2, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 2, 2025 14:03
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 2, 2025

Datadog Report

Branch report: enhancement/collection-tagfilters-first
Commit report: 65eb4e7
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 47.59s Total Time
➡️ Test Sessions change in coverage: 1 no change

Base automatically changed from enhancement-collection-do-not-render-empty-filter to main January 7, 2025 10:30
@adriangohjw adriangohjw enabled auto-merge (squash) January 7, 2025 10:36
@adriangohjw adriangohjw merged commit 69c314b into main Jan 7, 2025
16 of 18 checks passed
@adriangohjw adriangohjw deleted the enhancement/collection-tagfilters-first branch January 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants