Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isom-1722 - fix infobar margin top #998

Conversation

adriangohjw
Copy link
Contributor

Problem

Closes https://linear.app/ogp/issue/ISOM-1722/bug-multiple-infobar-in-a-row-will-cause-the-non-first-infobar-to-not

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • moving compoundStyles.outerContainer({ layout: simplifiedLayout }) into outer section
  • add stories

Before & After Screenshots

BEFORE:

image

AFTER:

image

Tests

  1. go to a content page and add multiple infobars
  2. the first infobars in the page should not have a margin top. the subsequent ones should have magins

@adriangohjw adriangohjw added the bug Something isn't working label Jan 18, 2025
@adriangohjw adriangohjw self-assigned this Jan 18, 2025
@adriangohjw adriangohjw requested a review from a team as a code owner January 18, 2025 16:54
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 18, 2025

Datadog Report

Branch report: adriangohjw/isom-1722-bug-multiple-infobar-in-a-row-will-cause-the-non-first
Commit report: 583f99a
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 48.46s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 58cd646 into main Jan 20, 2025
17 of 20 checks passed
@adriangohjw adriangohjw deleted the adriangohjw/isom-1722-bug-multiple-infobar-in-a-row-will-cause-the-non-first branch January 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants