Make bindings discoverable on system startup #15817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
enhancement
andrewfg
requested review from
miloit,
zarusz,
Skinah,
hmerk,
jlaur,
mlobstein,
cweitkamp,
kaikreuzer,
digitaldan,
mhilbush,
kgoderis,
lolodomo,
markus7017,
paulianttila,
peuter,
Stratehm,
morph166955,
stefan-hoehn,
clinique,
stefanroellin,
ibaton,
bobadair and
ppieczul
as code owners
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@mvalla many thanks for the suggestion. Done. |
mvalla
approved these changes
Dec 2, 2023
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/addon/addon.xml
Show resolved
Hide resolved
|
@kaikreuzer : I will review this one. But it can't be merged before core stuff. |
|
Thanks @lolodomo! I plan to merge openhab/openhab-core#3865 asap and then update the xsds on the website. I guess this should then be enough for this PR to correctly build and to be mergeable. |
I think so. (It does build already with -DskipChecks) |
andrewfg
added
rebuild
|
@lolodomo just to report that @kaikreuzer merged the core dependency, so this PR does indeed now build properly. And I just synchronized this PR with openhab-addons:main so everything should now be clean. |
andrewfg
changed the title
lolodomo
reviewed
Dec 7, 2023
bundles/org.openhab.binding.androidtv/src/main/resources/OH-INF/addon/addon.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lolodomo
approved these changes
Dec 7, 2023
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [discovery-methods] mDNS discovery methods * [discovery-methods] UPnP discovery methods --------- Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to the PRs listed below, this PR adds discovery method XML to 70 existing bindings, and thus makes them discoverable on system startup.
Addons with Issues
There are some bindings where issues have been identified, so these have not yet been included in this PR.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch