Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tado] Change humidity and heatingPower channels to QuantityType #16531

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

andrewfg
Copy link
Contributor

Migrate humidity and heatingPower channels from DecimalType to QuantityType.

Resolves #16358

See https://community.openhab.org/t/migrate-channel-type-of-existing-things/154648/1

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Mar 17, 2024
@andrewfg andrewfg self-assigned this Mar 17, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/migrate-channel-type-of-existing-things/154648/7

@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 17, 2024
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg removed the work in progress A PR that is not yet ready to be merged label Mar 18, 2024
@andrewfg andrewfg requested a review from jlaur March 18, 2024 11:14
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few minor comments for consideration.

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from jlaur March 21, 2024 15:14
@andrewfg
Copy link
Contributor Author

Therefore I would also highly recommend to test the migration, since even a small mistake (like this) can break the upgrade.

@jlaur in case it was not yet clear, I confirm that I did indeed test it; and can confirm it works fine.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7d8a1b1 into openhab:main Apr 1, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Apr 1, 2024
florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Apr 21, 2024
…oM metadata when adding from model (#2485)

When creating a new Number with Dimension item from a channel link, the
stateDescriptionPattern does not propose the state description pattern
from the channel type as the default.

This commit introduces this:

It only saves this state description pattern from the channel type to
metadata of the item if it is not the default state description pattern
for a Number type.

Subsequent edits of the item will present a disabled state description pattern input.
If no state description field is set, a blank field will be presented.
Reasons are:
- A state description can contain more than a pattern.
  Saving only the pattern would override the rest of the stateDescription.
- An Item can be linked to multiple channels with (possibly conflicting) stateDescription.
  The only solution would be for the user the set it on the item and override the channel stateDescriptions.

See openhab/openhab-addons#16531 (comment).

This PR also now saves the unit (and state description pattern) when creating equipment or point from a thing.

---------

Also-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
@andrewfg andrewfg deleted the tado-rh branch August 25, 2024 11:03
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
…nhab#16531)

* [tado] tweaks to xml

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tado] Change DecimalType channels to deliver QuantityType values
5 participants