-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tado] Change humidity and heatingPower channels to QuantityType #16531
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/migrate-channel-type-of-existing-things/154648/7 |
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few minor comments for consideration.
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@jlaur in case it was not yet clear, I confirm that I did indeed test it; and can confirm it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oM metadata when adding from model (#2485) When creating a new Number with Dimension item from a channel link, the stateDescriptionPattern does not propose the state description pattern from the channel type as the default. This commit introduces this: It only saves this state description pattern from the channel type to metadata of the item if it is not the default state description pattern for a Number type. Subsequent edits of the item will present a disabled state description pattern input. If no state description field is set, a blank field will be presented. Reasons are: - A state description can contain more than a pattern. Saving only the pattern would override the rest of the stateDescription. - An Item can be linked to multiple channels with (possibly conflicting) stateDescription. The only solution would be for the user the set it on the item and override the channel stateDescriptions. See openhab/openhab-addons#16531 (comment). This PR also now saves the unit (and state description pattern) when creating equipment or point from a thing. --------- Also-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…nhab#16531) * [tado] tweaks to xml Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Migrate humidity and heatingPower channels from DecimalType to QuantityType.
Resolves #16358
See https://community.openhab.org/t/migrate-channel-type-of-existing-things/154648/1
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch