-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UoM add units for humidity #4157
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
I think the g/kg unit makes sense. I am more reluctant about % r.H. To me this is still %, nothing else. |
Honestly if we choose not to do relative humidity then absolute humidity "by mass ratio" should probably also be cancelled. There are in fact three humidity measures -- namely relative humidity (%rH), absolute humidity "by mass ratio" (g/Kg), and absolute humidity "by volume" (g/m³). You don't like the former. The latter is already a standard unit of density. So if we drop those two, we may as well drop them all.
Yeah. I only really did that because I could not find a way to PREVENT conversion (i.e. make it throw an exception). Given that I could not prevent conversion I thought it best to at least return something that more-or-less correct -- rather than absolutely wrong.. |
@andrewfg I don’t agree with this. So creating an almost arbitrary conversion between incompatible measurements is a total no go to me. see also: |
Closing this. |
Resolves #4155
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch