Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hubspot immutables-exceptions #53

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Add hubspot immutables-exceptions #53

merged 2 commits into from
Sep 20, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 18, 2024

A new dependency of jinjava

@ccutrer
Add hubspot immutables-exceptions
081c509 
A new dependency of jinjava

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer mentioned this pull request Sep 18, 2024
Merged
@jimtng
Copy link
Contributor

jimtng commented Sep 19, 2024 •
edited
Loading

@wborn / @J-N-K at the moment the issue with mqtt.homeassistant is causing some problems when running/using the snapshot build. Hopefully this + the corresponding addon PR would fix it. Once merged, the build needs to be triggered for openhab-osgiify

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 20, 2024

Ping @lsiepel

@lsiepel
Copy link

lsiepel commented Sep 20, 2024

I would expect this to also be added to the root pom.xml as module

@ccutrer
add to root pom
e67522b 
Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 20, 2024

I would expect this to also be added to the root pom.xml as module

🤦 good call. done

lsiepel
lsiepel approved these changes Sep 20, 2024
View reviewed changes
Copy link

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
@wborn or @J-N-K can you start the build to publish the artifacts?

@lsiepel lsiepel merged commit 7080cc1 into openhab:main Sep 20, 2024
3 checks passed
@ccutrer ccutrer deleted the hubspot-immutables-exceptions branch September 20, 2024 19:02
@J-N-K
Copy link
Member

J-N-K commented Sep 20, 2024

Done

@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 20, 2024

https://ci.openhab.org/view/Release%20Jobs/job/openhab-osgiify/40/console failed (with the encoding thing), and needs run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccutrer @jimtng @lsiepel @J-N-K