Skip to content

Commit

Permalink
Health menu: Remove sidebar and settings entry, instead use FAB (#2652)
Browse files Browse the repository at this point in the history
Closes #2644.

This removes the health check entry from the sidebar and the settings
menu and instead uses a floating action button (FAB) to allow access to
the health checks page if there are any actual issues.

---------

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
  • Loading branch information
florian-h05 authored Jul 7, 2024
1 parent 7225c0d commit 10746f1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 17 deletions.
4 changes: 0 additions & 4 deletions bundles/org.openhab.ui/web/src/components/app.vue
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@
</f7-list-item>
<li v-if="showSettingsSubmenu">
<ul class="menu-sublinks">
<f7-list-item v-if="$store.getters.apiEndpoint('links')" link="/settings/health/" title="Health checks" view=".view-main" panel-close :animate="false" no-chevron
:class="{ currentsection: currentUrl.indexOf('/settings/health') === 0 }">
<f7-icon slot="media" f7="heart" color="gray" />
</f7-list-item>
<f7-list-item v-if="$store.getters.apiEndpoint('things')" link="/settings/things/" title="Things" view=".view-main" panel-close :animate="false" no-chevron
:class="{ currentsection: currentUrl.indexOf('/settings/things') === 0 }">
<f7-icon slot="media" f7="lightbulb" color="gray" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<f7-page @page:afterin="onPageAfterIn">
<f7-navbar title="Orphan links" back-link="Health checks" back-link-url="/settings/health/" back-link-force>
<f7-navbar title="Orphan Links" back-link="Health Checks" back-link-url="/settings/health/" back-link-force>
<f7-nav-right>
<developer-dock-icon />
</f7-nav-right>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<f7-page @page:afterin="onPageAfterIn">
<f7-navbar title="Health checks" back-link="Settings" back-link-url="/settings/" back-link-force>
<f7-navbar title="Health Checks" back-link="Settings" back-link-url="/settings/" back-link-force>
<f7-nav-right>
<developer-dock-icon />
</f7-nav-right>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,6 @@
<f7-col :class="!addonsLoaded || (addonsLoaded && addonsInstalled.length > 0) ? 'settings-col' : ''" width="100" medium="50">
<f7-block-title>Configuration</f7-block-title>
<f7-list media-list class="search-list">
<f7-list-item
v-if="$store.getters.apiEndpoint('links')"
media-item
link="health/"
title="Health check"
:badge="(healthCount > 0) ? healthCount : undefined"
:after="(healthCount > 0) ? undefined : 0"
badge-color="red"
:footer="objectsSubtitles.health">
<f7-icon slot="media" f7="heart" color="gray" />
</f7-list-item>
<f7-list-item
v-if="$store.getters.apiEndpoint('things')"
media-item
Expand Down Expand Up @@ -199,6 +188,10 @@
<small v-t="'admin.notTranslatedYet'" />
</f7-block-footer>
</f7-block>

<f7-fab v-if="healthCount > 0" position="center-bottom" :text="`Health Issues (${healthCount})`" slot="fixed" color="red" href="health/">
<f7-icon f7="heart" />
</f7-fab>
</f7-page>
</template>

Expand Down

0 comments on commit 10746f1

Please sign in to comment.