Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid chart period "3M" of sitemaps #2160

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Fix invalid chart period "3M" of sitemaps #2160

merged 1 commit into from
Nov 4, 2023

Conversation

stefanroellin
Copy link
Contributor

"3M" for three months is an invalid chart period for a sitemap. Replace it with "4M" for four months, which is missing.

See https://next.openhab.org/docs/ui/sitemaps.html#element-type-chart

@stefanroellin stefanroellin requested a review from a team as a code owner November 3, 2023 16:43
@stefanroellin
Fix chart periods of sitemaps
6302fe7 
"3M" for three months is an invalid chart period for a sitemap.
Replace it with "4M" for four months, which is missing.

Signed-off-by: Stefan Roellin <stefan@roellin-baumann.ch>
@relativeci RelativeCI
Copy link

relativeci bot commented Nov 3, 2023

Job #1236: Bundle Size — 15.75MiB (-0.1%).

6302fe7(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1236		      Baseline
Job #1158
Regression  Initial JS 1.85MiB(+10.97%) 1.67MiB
Regression  Initial CSS 609.06KiB(+0.03%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 1 regression Improvement 2 improvements
                 Current
Job #1236		      Baseline
Job #1158
Improvement  JS 9.24MiB (-0.17%) 9.25MiB
Improvement  Other 4.73MiB (-0.02%) 4.73MiB
Regression  CSS 860.29KiB (+0.09%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1236 report View stefanroellin:fix-chart-periods branch activity

florian-h05
florian-h05 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Nov 4, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Nov 4, 2023
@florian-h05 florian-h05 changed the title Fix chart periods of sitemaps Fix invalid chart period "3M" of sitemaps Nov 4, 2023
@florian-h05 florian-h05 merged commit 4103c08 into openhab:main Nov 4, 2023
5 checks passed
@stefanroellin stefanroellin deleted the fix-chart-periods branch November 4, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanroellin @florian-h05