Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Addon suggestions" #2199

Closed
wants to merge 1 commit into from
Closed

Revert "Addon suggestions" #2199

wants to merge 1 commit into from

Conversation

ghys
Copy link
Member

@ghys ghys commented Dec 5, 2023

Reverts #2150.

Fixes #2197.

@openhab/webui-maintainers @mherwege @andrewfg do you think we should revert the change ASAP, or wait for the core PR (openhab/openhab-core#3806)?

Copy link

relativeci bot commented Dec 5, 2023

Job #1286: Bundle Size — 15.81MiB (+0.3%).

4073d46(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1286
     Baseline
Job #1158
Regression  Initial JS 1.89MiB(+13.18%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3027(+78.06%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1286
     Baseline
Job #1158
Regression  JS 9.28MiB (+0.32%) 9.25MiB
Regression  Other 4.74MiB (+0.33%) 4.73MiB
Regression  CSS 860.87KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1286 reportView revert-2150-suggestions branch activity

@kaikreuzer
Copy link
Member

I'm confident that we can merge the core PR by the end of this week. So I would not revert this one here.

@ghys
Copy link
Member Author

ghys commented Dec 8, 2023

No need for this anymore since openhab/openhab-core#3806 is now merged.

@ghys ghys closed this Dec 8, 2023
@florian-h05 florian-h05 deleted the revert-2150-suggestions branch December 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial setup : no more possible to select add-ons to be installed with OH 4.1M4
2 participants