Fix navigation issues with model cards #2211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#2196. Reverts openhab#2074. I have tried messing around with the browser history manually to fix that issue, however trying several approaches, none worked perfect. This is the best solution I could come up with, it at least remembers which tab you had opened when you navigate back to the home page from any other page. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@ghys Can you please have a look at this soon? (Not code-wise, but about the approach.) This is an important fix for 4.1. |
Job #1301: Bundle Size — 15.81MiB (+0.32%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1301 report View florian-h05:fix-2196 branch activity |
|
Yes I will have a close look at it this week. |
|
@florian-h05 #2221 should fix the problem and keep the routes. |
florian-h05
pushed a commit
that referenced
this pull request
Dec 15, 2023
Fixes #2196. Replaces #2211. The double back navigation was caused by: https://github.com/framework7io/framework7/blob/31f4c7065e8abe9b8b27f354de4e390a8cd584c0/src/core/utils/history.js#L56-L61 and `router.updateCurrentUrl()`, unlike the name implies, doesn't update `router.url` for some reason (maybe a bug?). ----- Signed-off-by: Yannick Schaus <github@schaus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2196.
Reverts #2074.
I have tried messing around with the browser history manually to fix that issue, however trying several approaches, none worked perfect. This is the best solution I could come up with, and it at least remembers which tab you had opened when you navigate back to the home page from any other page.