-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons store: Use swiper for addon cards on mobile & Reduce size of addon card on desktop #2216
Conversation
#2416 Bundle Size — 10.85MiB (+0.01%).919f65c(current) vs 331f794 main#2413(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2416 |
Baseline #2413 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 17.74% |
22.69% |
Chunks | 226 |
226 |
Assets | 249 |
249 |
Modules | 2930 (+0.1% ) |
2927 |
Duplicate Modules | 151 |
151 |
Duplicate Code | 1.88% |
1.88% |
Packages | 96 |
96 |
Duplicate Packages | 2 |
2 |
Bundle size by type 2 changes
2 regressions
Current #2416 |
Baseline #2413 |
|
---|---|---|
JS | 9.06MiB (+0.02% ) |
9.06MiB |
CSS | 864.19KiB (+0.02% ) |
864.03KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch florian-h05:addon-logo-size Project dashboard
Generated by RelativeCI Documentation Report issue
482ae6c
to
eac4c62
Compare
Thanks, good attempt. Maybe a few remarks here:
|
I tried to fix that, while doing that, I noticed that the vertical gap actually was not to large, but there was no horizontal gap left.
Yes, that's not nice, but I don't have a better idea ...
The problem is, that this is controlled by CSS, so it is not that easy to control it from JS.
I have had a look at this, it feels a bit weird to not have the install/remove button for those, but for the list.
That is a really nice proposal. |
…mobile Signed-off-by: Florian Hotze <dev@florianhotze.com>
f33a79b
to
919f65c
Compare
Done 👍
Implemented: |
Let’s give it a try 👍 |
… size change Follow-up for openhab#2216. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Follow-up for #2216. - Do not use addon swiper on iPad. - Revert addon card size changes. - Show more addon cards in swiper in landscape mode. --------- Signed-off-by: Florian Hotze <dev@florianhotze.com>
Fixes #2205 and fixes #1668.
This slighly reduces the addon card size on desktop and uses a swiper (like in many app stores) instead of a flex on mobile.