Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing edit: Fix changing ID shows wrong value & Always show UID #2475

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Thing edit: Fix changing ID shows wrong value & Always show UID #2475

merged 1 commit into from
Mar 13, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2469.

After changing the ID of a Thing (only possible when creating a new Thing), the displayed value was reset to the pre-filled default when moving to a different field. When saving the Thing, the entered value was used. This was because Vue did not properly notice the change of the ID.

@florian-h05
Thing edit: Fix changing ID shows wrong value & Always show UID
47550f5 
Fixes openhab#2469.

After changing the ID of a Thing (only possible when creating a new Thing), the displayed value was reset to the pre-filled default when moving to a different field.
When saving the Thing, the entered value was used.
This was because Vue did not properly notice the change of the ID.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 13, 2024 11:36
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 13, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 13, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 13, 2024

Job #1802: Bundle Size — 11.13MiB (~+0.01%).

47550f5(current) vs 7db99cb main#1799(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1802		      Baseline
Job #1799
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
No change  Cache Invalidation 17.13% 17.13%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3092 3092
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1802		      Baseline
Job #1799
Regression  JS 9.32MiB (~+0.01%) 9.32MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1802 report View florian-h05:thing-id-change branch activity View project dashboard

@florian-h05 florian-h05 merged commit 1ceb5c6 into openhab:main Mar 13, 2024
6 checks passed
@florian-h05 florian-h05 deleted the thing-id-change branch March 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Changing Thing UID reverts to default
1 participant
@florian-h05