Downgrade pkce-challenge to fix authentication for insecure (HTTP) contexts #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 4.x of pkce-challenge uses the Web Crypto API, which is only available in secure contexts (https) in most browsers. See https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
changed the title
florian-h05
changed the title
Job #1875: Bundle Size — 10.56MiB (+0.06%).Warning Bundle contains 2 duplicate packages – View duplicate packages Warning Bundle introduced one new package: crypto-js – View changed packages Bundle metrics
  
Bundle size by type
View job #1875 report View florian-h05:pkce-challenge branch activity View project dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #2488.
Version 4.x of pkce-challenge uses the Web Crypto API, which is only available in secure contexts (https) in most browsers.
This broke the login when accessing the UI over an insecure (plain HTTP) connection.
See https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API.