Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow future periods in sitemap configuration #2529

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Apr 8, 2024

Chart widget sitemap configuration has been extended with support for future periods in openhab/openhab-core#4172.
This adds configuration in the UI.

See: #2518

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner April 8, 2024 10:00
Copy link

relativeci bot commented Apr 8, 2024

Job #1891: Bundle Size — 10.56MiB (~+0.01%).

126a271(current) vs 4a0054a main#1889(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1891
     Baseline
Job #1889
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.8% 18.3%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2861 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1891
     Baseline
Job #1889
Regression  JS 8.75MiB (+0.01%) 8.75MiB
Not changed  CSS 890.07KiB 890.07KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1891 reportView mherwege:chart-period branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit 1232bf5 into openhab:main Apr 12, 2024
6 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Apr 12, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Apr 12, 2024
@mherwege mherwege deleted the chart-period branch April 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants