[BasicUI] Add special handling for "none" icon #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same behaviour as in the Android app is now implemented for the "none" icon. This icon means "no icon" and we don't want to request the icon servlet. When this icon is associated to a sitemap element, the icon servletis no more requested. Instead, a simple empty SVG tag is considered and inserted in the HTML page. There is also no dynamic behaviour (with item state) applied for this icon. Additionally, in case the loading of any OH icon fails, the IMG tag is replaced by an empty SVG tag in the HTML page. Fix openhab/openhab-core#3977 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
reviewed
Apr 21, 2024
...nhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/AbstractWidgetRenderer.java
Outdated
Show resolved
Hide resolved
mueller-ma
added a commit
to mueller-ma/openhab.android
that referenced
this pull request
Apr 22, 2024
See openhab/openhab-webui#2534 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
mueller-ma
added a commit
to mueller-ma/openhab.android
that referenced
this pull request
Apr 22, 2024
See openhab/openhab-webui#2534 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
mueller-ma
added a commit
to openhab/openhab-android
that referenced
this pull request
Apr 29, 2024
See openhab/openhab-webui#2534 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
|
Are now |
|
At least for Android it's handled the same way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same behaviour as in the Android app is now implemented for the "none" icon. This icon means "no icon" and we don't want to request the icon servlet. When this icon is associated to a sitemap element, the icon servlet is no more requested. Instead, a simple empty SVG tag is considered and inserted in the HTML page. There is also no dynamic behaviour (with item state) applied for this icon.
Additionally, in case the loading of any OH icon fails, the IMG tag is replaced by an empty SVG tag in the HTML page instead of updating the IMG source with the none icon URL (triggering a potential new icon servlet request).
Fix openhab/openhab-core#3977
Signed-off-by: Laurent Garnier lg.hc@free.fr