[BasicUI] Fix slider behaviour and implement two different modes #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
bug
lolodomo
force-pushed
the
slider_fix
branch
10 times, most recently
from
651099e to
215b026
Compare
Fix openhab#2525 Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430 Two behaviour modes are now supported. - If releaseOnly parameter is set, the new value is sent to the item only when the slider is released. - If releaseOnly parameter is not set, new values are sent to the item while moving the slider. Events are sent at a certain frequency, this frequency is defined by the sendFrequency parameter if set or every 200 ms by default. Event is not sent when the value is is unchanged (when stopping the move but keeping the mouse pressed). The brightness slider of the colorpicker widget is also updated to send regular new color commands when moving the slider. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Change tested with success using Firefox, Chrome and Edge on Windows 10 and using Chrome on an Android phone. Note that the previous implementation tries to handle browsers not respecting the standard* but with problems with all browsers respecting this standard. *Expected behaviour for a browser is to trigger "input" events when the slider is moving but not "change" events. "change" event should be triggered only when the slider is finally released. I read that 10 years ago, browsers like Internet Explorer were triggering "change" events while the slider was moving. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Keep a hardcoded interval of 200ms Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 18, 2024
Follow up openhab#2535 The function reloadIcon is already called by the function setValue at line 636 just before calling setValuePrivate. The icon continues being refreshed while moiving the slider except if releaseOnly parameter is set. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
May 18, 2024
Follow up openhab#2535 The function reloadIcon is already called by the function setValue at line 636 just before calling setValuePrivate. The icon continues being refreshed while moving the slider except if releaseOnly parameter is set. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2525
Also related to openhab/openhab-core#4084 and openhab/openhab-core#3430
Two behaviour modes are now supported.
The brightness slider of the colorpicker widget is also updated to send regular new color commands when moving the slider.
Signed-off-by: Laurent Garnier lg.hc@free.fr