Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openhab-js tern defs #2627

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jun 25, 2024

This updates the tern defs used for autocompletion to the current library version included in the add-on (5.2.0).
See openhab/openhab-js@v5.0.0...v5.2.0 for changes.

Last update was in #2563.

This updates the tern defs used for autocompletion to the current library version included in the add-on (5.2.0).
See openhab/openhab-js@v5.0.0...v5.2.0 for changes.

Last update was in openhab#2563.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner June 25, 2024 18:48
@florian-h05
Copy link
Contributor Author

FYI @mherwege

Copy link

relativeci bot commented Jun 25, 2024

#2048 Bundle Size — 10.64MiB (~+0.01%).

3b5ae13(current) vs 2a830a6 main#2045(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2048
     Baseline
#2045
No change  Initial JS 1.87MiB 1.87MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 17.75% 18.69%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2048
     Baseline
#2045
Regression  JS 8.83MiB (+0.01%) 8.83MiB
No change  CSS 891.55KiB 891.55KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:ohjs-tern-defsProject dashboard

@mherwege
Copy link
Contributor

FYI @mherwege

Thanks. I didn´t know how to do that part.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 25, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jun 25, 2024
@florian-h05
Copy link
Contributor Author

Yeah, it took me some time to figure out where the autocompletion gets its definitions from, probably I had to ask Yannick.
After I found out, I documented that in the CONTRIBUTING.md of the openhab-js repo: https://github.com/openhab/openhab-js/blob/main/CONTRIBUTING.md#main-ui-code-completion

@florian-h05 florian-h05 merged commit eb975c1 into openhab:main Jun 25, 2024
8 checks passed
@florian-h05 florian-h05 deleted the ohjs-tern-defs branch June 25, 2024 18:56
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Jul 4, 2024
This updated the tern defs used for autocompletion to the current
library version included in the add-on (5.3.1).

See openhab/openhab-js@v5.2.0...v5.3.1 for changes.

Last update was in openhab#2627.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 removed the enhancement New feature or request label Jul 4, 2024
florian-h05 added a commit that referenced this pull request Jul 4, 2024
Depens on openhab/openhab-addons#16985.

This updated the tern defs used for autocompletion to the current
library version included in the add-on (5.3.1).

See openhab/openhab-js@v5.2.0...v5.3.1 for
changes.

Last update was in #2627.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants