Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in orphanlinks page #2643

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix a typo in orphanlinks page #2643

merged 1 commit into from
Jul 5, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jul 5, 2024

No description provided.

@jimtng
Fix a typo in orphanlinks page
b17bc45 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner July 5, 2024 06:29
@florian-h05
Copy link
Contributor

@kaikreuzer Is it okay to merge such PRs during the code freeze?

@relativeci RelativeCI
Copy link

relativeci bot commented Jul 5, 2024

#2093 Bundle Size — 10.68MiB (0%).

b17bc45(current) vs d4ad028 main#2092(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2093		      Baseline
#2092
No change  Initial JS 1.88MiB 1.88MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 18.26% 17.75%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2894 2894
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  no changes
                 Current
#2093		      Baseline
#2092
No change  JS 8.86MiB 8.86MiB
No change  CSS 891.55KiB 891.55KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:orphanlinks-typo Project dashboard

@kaikreuzer
Copy link
Member

Up to the maintainers to decide. 😄
Both potential decisions are ok from my pov.

florian-h05
florian-h05 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch!

I will merge this PR inside the code freeze, as it’s no „real“ code change, just a description of a HTML element.

@florian-h05 florian-h05 added the main ui Main UI label Jul 5, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jul 5, 2024
@florian-h05 florian-h05 merged commit 0666794 into openhab:main Jul 5, 2024
8 checks passed
@jimtng jimtng deleted the orphanlinks-typo branch July 5, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jimtng @florian-h05 @kaikreuzer