Make tabbed pages routable #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to route through tabbed page by their index, i.e. 0 for the first tab and so on. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
@digitaldan Now that we can navigate the UI when clicking a notification, the UI needs to be able to navigate tabbed pages through routes. This implements this! |
#2095 Bundle Size — 10.67MiB (-0.06%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2095 |
Baseline #2094 |
|
|---|---|---|
 Initial JS |
1.88MiB(+0.01%) |
1.88MiB |
 Initial CSS |
607.91KiB |
607.91KiB |
 Cache Invalidation |
17.82% |
18.26% |
| Chunks |
223 |
223 |
| Assets |
246 |
246 |
| Modules |
2888(-0.21%) |
2894 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.85% |
1.85% |
| Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 improvement
| Current #2095 |
Baseline #2094 |
|
|---|---|---|
| JS |
8.86MiB (-0.08%) |
8.86MiB |
| CSS |
891.55KiB |
891.55KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:tabbed-pages-routing Project dashboard
florian-h05
added a commit
to florian-h05/openhab-docs
that referenced
this pull request
Jul 5, 2024
Depends on openhab/openhab-webui#2647. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
Docs PR: openhab/openhab-docs#2326 |
|
Thats excellent! Someone asked about this exact feature when we released the command item, so i know its going to be well received . |
stefan-hoehn
pushed a commit
to openhab/openhab-docs
that referenced
this pull request
Jul 16, 2024
Depends on openhab/openhab-webui#2647. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to route through tabbed page by their index, i.e. 0 for the first tab and so on.