-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oh-sipclient: Add Item to report SIP status to server #2648
Conversation
#2111 Bundle Size — 10.67MiB (~+0.01%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2111 |
Baseline #2107 |
|
---|---|---|
Initial JS | 1.88MiB (+0.04% ) |
1.88MiB |
Initial CSS | 607.91KiB |
607.91KiB |
Cache Invalidation | 17.58% |
17.95% |
Chunks | 223 |
223 |
Assets | 246 |
246 |
Modules | 2888 |
2888 |
Duplicate Modules | 149 |
149 |
Duplicate Code | 1.85% |
1.85% |
Packages | 97 |
97 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2111 |
Baseline #2107 |
|
---|---|---|
JS | 8.86MiB (~+0.01% ) |
8.86MiB |
CSS | 892.63KiB |
892.63KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.24KiB |
1.24KiB |
Other | 871B |
871B |
Bundle analysis report Branch florian-h05:sipclient-statusitem Project dashboard
@digitaldan WDYT? |
Seems like a cool feature! One suggestion would be to have the item be able to be configured per browser (so using local storage) like we allow for other SIP configuration options, so add this to the localSettingsPopup part of the widget. I have 5 (sometimes more) tablets that all pop up the SIP widget when a call comes in and i could see wanting to track those separately. On a bit of a tangent. I have a Freeswitch PBX docker container i run that my SIP devices (like my grand stream gate phone) connect to as well as some external phone numbers. When a call comes in, its responsible for triggering an item update on openHAB which pops up my sip widgets. Freeswitch keeps the incoming call ringing, even though my sip widgets are not registered yet, then when they do pop up and register, it immediately rings them. This is similar to how VOIP apps on mobile devices work, where the PBX sends a push notification that there is a call, which then wakes up the mobile sip app which immediately registers then gets sent the call. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
ed7aa3c
to
896365f
Compare
Agreed, sounds reasonable. WDYT about the strings that are sent? Understandable and detailed enough? |
Yeah, LGTM! |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@digitaldan Can you please take a look at it? I have added support for local setting of the call state Item and extended its values to also include the caller ID. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
55d68bc
to
3558729
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This regenerated the component docs after #2648. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This adds the option to specify a String Item, to which the SIP connection status is sent.
This allows to track the usage of oh-sipclient from rules and scripts.