Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BasicUI] Fix frame title's left padding in condensed tablet layout #2700

Merged
merged 1 commit into from
Aug 10, 2024
Merged

[BasicUI] Fix frame title's left padding in condensed tablet layout #2700

merged 1 commit into from
Aug 10, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 10, 2024 •
edited
Loading

Before:

image

After:

image

@jimtng
[BasicUI] Fix frame title's left padding in condensed tablet layout
d5763ed 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner August 10, 2024 00:41
@lolodomo lolodomo added bug Something isn't working basic ui Basic UI labels Aug 10, 2024
lolodomo
lolodomo approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 77d42c1 into openhab:main Aug 10, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Aug 10, 2024
@jimtng jimtng deleted the basicui-form-title branch August 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
basic ui Basic UI bug Something isn't working
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @lolodomo