Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thing Add: Validate Thing ID before saving #3009

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Thing Add: Validate Thing ID before saving #3009

merged 1 commit into from
Jan 13, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 13, 2025

No description provided.

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 13, 2025 •
edited
Loading

#2693 Bundle Size — 10.98MiB (~+0.01%).

7d82fdd(current) vs e7d9b65 main#2689(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2693		      Baseline
#2689
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 18.04% 19.12%
No change  Chunks 227 227
No change  Assets 250 250
Change  Modules 2951(+0.03%) 2950
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2693		      Baseline
#2689
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.02KiB 867.02KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch jimtng:thing-id-validate Project dashboard

Generated by RelativeCI Documentation Report issue

@jimtng jimtng force-pushed the thing-id-validate branch from 9158731 to d9d943e Compare January 13, 2025 00:34
@jimtng jimtng marked this pull request as draft January 13, 2025 00:36
@jimtng jimtng force-pushed the thing-id-validate branch 2 times, most recently from c6e7e6a to aec5287 Compare January 13, 2025 02:15
@jimtng
Thing Add: Validate Thing ID before saving
7d82fdd 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the thing-id-validate branch from aec5287 to 7d82fdd Compare January 13, 2025 02:41
@jimtng jimtng marked this pull request as ready for review January 13, 2025 02:47
florian-h05
florian-h05 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Nice enhancement.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 13, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 13, 2025
@florian-h05 florian-h05 merged commit 9a9d363 into openhab:main Jan 13, 2025
5 checks passed
@jimtng jimtng deleted the thing-id-validate branch January 13, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @florian-h05