Allow to configure the plugin to fail on any severity #478
+69
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-m-s
force-pushed
the
allow-to-fail-on-different-severities
branch
from
a3fd025 to
6229b3d
Compare
…ues. This is necessary to ease the integration to cicd with requirements to not pass if any static code violation is found, without needing to configure the checkstyle, pmd and findbugs in depth to produce only error level, which is hard to do and can be difficult to maintain regarding future versions. Signed-off-by: David Mas <david.mas@ocado.com>
david-m-s
force-pushed
the
allow-to-fail-on-different-severities
branch
from
6229b3d to
c7fc89a
Compare
wborn
reviewed
Jan 19, 2025
Comment on lines
+374
to
+375
| throw new MojoFailureException(String.format("%n" + "Code Analysis Tool has found %d error(s)! %n" | ||
| + "Please fix the errors and rerun the build. %n", errorCount)); |
There was a problem hiding this comment.
This message may need an update as well depending on the configuration. Users might think only fixing errors should be enough but if you configure it to fail on warnings/info this is no longer the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to ease the integration to cicd with requirements to not pass if any static code violation is found, without needing to configure the checkstyle, pmd and findbugs in depth to produce only error level. It s hard to configure each individual plugin (if at all possible) and can be difficult to maintain regarding future versions.