8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests

[alexeysemenyukoracle]

• Don't remove the PATH variable from the environment when running app launchers in jpackage tests;
• Fix tests that use Executor rather than HelloApp class to run app launchers: apply the same changes to the environment as would be applied by HelloApp class.
• Replace Executor.setRemovePathEnvVar() with Executor.removeEnvVar() to support removal of any variable from the environment of a child process executed in jpackage tests;
• Add support of a new boolean property jpackage.test.clear-app-launcher-java-env-vars in jpackage tests. If it is set to "true", the JAVA_TOOL_OPTIONS and _JAVA_OPTIONS variables will be removed from the environment of app launchers executed in jpackage tests. It is handy in local testing using jpackage test runner instead of the jtreg.

The first and the second changes are unrelated to other changes. They are bundled together as they apply to the same source code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests (Enhancement - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22983/head:pull/22983
$ git checkout pull/22983

Update a local copy of the PR:
$ git checkout pull/22983
$ git pull https://git.openjdk.org/jdk.git pull/22983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22983

View PR using the GUI difftool:
$ git pr show -t 22983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22983.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a865317a)
• 00: Full (dce50596)

[alexeysemenyukoracle]

@sashamatveev PTAL

[sashamatveev]

Looks good.