8347298: Bug in JPackageCommand.ignoreFakeRuntime()

[alexeysemenyukoracle]

JPackageCommand.ignoreFakeRuntime() method mistakenly tests if Java runtime configured for the current jpackage command is a valid Java runtime.

It must test the runtime configured for jpackage tests with jdk.jpackage.test.runtime-image system property instead.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347298: Bug in JPackageCommand.ignoreFakeRuntime() (Bug - P3)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22986/head:pull/22986
$ git checkout pull/22986

Update a local copy of the PR:
$ git checkout pull/22986
$ git pull https://git.openjdk.org/jdk.git pull/22986/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22986

View PR using the GUI difftool:
$ git pr show -t 22986

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22986.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347298: Bug in JPackageCommand.ignoreFakeRuntime()

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fefb1a7c)

[alexeysemenyukoracle]

@sashamatveev PTAL

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 01c8ba2.
Since your change was applied there have been 49 commits pushed to the master branch:

• d69463e: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests
• 4b554b5: 8346722: (fs) Files.probeContentType throws ClassCastException with custom file system provider
• 46ba515: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args
• e7e8f60: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless
• 9cf7d42: 8346184: C2: assert(has_node(i)) failed during split thru phi
• 1bf2f5c: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
• beb0e60: 8347397: Cleanup of JDK-8169880
• c5c4efd: 8347120: Launchers should not have java headers on include path
• ec7393e: 8347287: JFR: Remove use of Security Manager
• 12752b0: 8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary
• ... and 39 more: https://git.openjdk.org/jdk/compare/ea49537726db6530f0ddcc04d9938df3d6d18250...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 01c8ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.