Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347302: Mark test tools/jimage/JImageToolTest.java as flagless #22992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jan 9, 2025

Test
test/jdk/tools/jimage/JImageToolTest.java
ignore vm flags and should be marked as flagless.

It is needed to don't try to run this test with virtual test thread factory.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347302: Mark test tools/jimage/JImageToolTest.java as flagless (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22992/head:pull/22992
$ git checkout pull/22992

Update a local copy of the PR:
$ git checkout pull/22992
$ git pull https://git.openjdk.org/jdk.git pull/22992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22992

View PR using the GUI difftool:
$ git pr show -t 22992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22992.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347302: Mark test tools/jimage/JImageToolTest.java as flagless

Reviewed-by: alanb, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • d66737e: 8341097: GHA: Demote Mac x86 jobs to build only
  • dff5719: 8347126: gc/stress/TestStressG1Uncommit.java gets OOM-killed
  • 82e16ba: 8347268: [ubsan] logOutput.cpp:357:21: runtime error: applying non-zero offset 1 to null pointer
  • 33f9be8: 8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests
  • 8eddf67: 8346887: DrawFocusRect() may cause an assertion failure
  • a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • 97dd06c: 8347299: Add annotations to test cases in LicenseTest
  • 0a35ebf: 8347297: Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed outside of the jtreg
  • b3e8736: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
  • 1ade96b: 8347042: Remove an extra parenthesis in macro definition in jfrTraceIdMacros.hpp
  • ... and 2 more: https://git.openjdk.org/jdk/compare/ea49537726db6530f0ddcc04d9938df3d6d18250...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@lmesnik The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants