Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347279: Problemlist TestEvilSyncBug.java#generational #22996

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 9, 2025

Hi all,
Test gc/shenandoah/TestEvilSyncBug.java#generational was observed times out on a lot of platforms (various Linux and Windows too) several times recently. Should we Problemlist this test before the failure root cause been fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347279: Problemlist TestEvilSyncBug.java#generational (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22996/head:pull/22996
$ git checkout pull/22996

Update a local copy of the PR:
$ git checkout pull/22996
$ git pull https://git.openjdk.org/jdk.git pull/22996/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22996

View PR using the GUI difftool:
$ git pr show -t 22996

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22996.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347279: Problemlist TestEvilSyncBug.java#generational

Reviewed-by: tschatzl, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 1ef77cd: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory
  • 72f1114: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters
  • cb9a98b: 8347141: Several javac tests compile with an unnecessary -Xlint:-path flag
  • f9b1133: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
  • 9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
  • 3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
  • 2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
  • ceae2b9: 8347121: Add missing @serial tags to module java.base
  • 8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
  • 765b9e6: 8346706: RISC-V: Add available registers to hs_err
  • ... and 7 more: https://git.openjdk.org/jdk/compare/0a35ebfd5709c3069fd64bb736bbbc37d392759c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@sendaoYan
Copy link
Member Author

/label add hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@sendaoYan
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.

@sendaoYan
Copy link
Member Author

Thanks all for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

Going to push as commit f6492aa.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 0210a63: 8347379: Problem list failed tests after JDK-8321413
  • a9351df: 8346787: Fix two C2 IR matching tests for RISC-V
  • 89ee1a5: 8343978: Update the default value of CodeEntryAlignment for Ampere-1A and 1B
  • 931914a: 8340631: assert(reserved_rgn->contain_region(base_addr, size)) failed: Reserved CDS region should contain this mapping region
  • 665c39c: 8347375: Extra

    tag in robot specification

  • b335ea9: 8347122: Add missing @serial tags to module java.desktop
  • df28cec: 8345144: Robot does not specify all causes of IllegalThreadStateException
  • 9f3c5f9: 8344907: NullPointerException in Win32ShellFolder2.getSystemIcon when "icon" is null
  • 22f70a7: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image
  • 3bfa952: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements
  • ... and 17 more: https://git.openjdk.org/jdk/compare/0a35ebfd5709c3069fd64bb736bbbc37d392759c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2025
@openjdk openjdk bot closed this Jan 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@sendaoYan Pushed as commit f6492aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8345501 branch January 10, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants